chore[test]: add test for address members' names as struct fields #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3527 +/- ##
==========================================
+ Coverage 92.12% 92.14% +0.02%
==========================================
Files 119 119
Lines 16962 16962
Branches 2872 2872
==========================================
+ Hits 15626 15630 +4
Misses 919 919
+ Partials 417 413 -4 ☔ View full report in Codecov by Sentry. |
|
i think reserving those attributes to not be available on structs/enums is kind of ok. |
|
but yea, maybe it's useful sometimes to have structs with information like |
This reverts commit 9de0941.
…address_members_as_struct
tserg
changed the title
|
@tserg could you update to the new kwarg syntax? |
…address_members_as_struct
|
Done! |
charles-cooper
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix #3521.
How I did it
Remove the
elsebranch inparse_Attributeso that structs can be catched.How to verify it
See test.
Commit message
Description for the changelog
Allow address members' names as struct fields.
Cute Animal Picture